add array support to rust/jsg #5868
Open
+1,531
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
yagiz/add-array-suport
branch
from
35b2d20 to
a117878
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
guybedford
reviewed
Jan 14, 2026
Contributor
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
Can Arrays of GC references be handled? There don't seem to be any test cases covering this. What happens for Vec<Ref> with this implementation currently?
Fine to defer, just nice to know what the situation is.
Comment on lines
+35
to
+40
| //! | `Vec<u8>` | `Uint8Array` | | ||
| //! | `Vec<u16>` | `Uint16Array` | | ||
| //! | `Vec<u32>` | `Uint32Array` | | ||
| //! | `Vec<i8>` | `Int8Array` | | ||
| //! | `Vec<i16>` | `Int16Array` | | ||
| //! | `Vec<i32>` | `Int32Array` | |
Contributor
There was a problem hiding this comment.
What about byte slice representations for Uint arrays? For example supporting [u8] for a Uint8Array.
Comment on lines
+320
to
+327
| pub struct Array; | ||
| pub struct TypedArray; | ||
| pub struct Uint8Array; | ||
| pub struct Uint16Array; | ||
| pub struct Uint32Array; | ||
| pub struct Int8Array; | ||
| pub struct Int16Array; | ||
| pub struct Int32Array; |
Contributor
There was a problem hiding this comment.
What about Float32Array and BigInt arrays?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds array support to the Rust/JSG layer.
Some other notable changes: