Skip to content

[build] Overhaul CI configuration #5805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fhanau wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[build] Overhaul CI configuration #5805

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96d7a24
[build] Overhaul CI configuration
fhanau Dec 31, 2025
94afa6b
[ci] Disable lld on macOS non-release CI again
fhanau Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/actions/setup-runner/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ runs:
if: runner.os == 'Windows'
# Set a custom output root directory to avoid long file name issues.
run: |
# Enable Developer Mode to allow Bazel to create real symlinks
Copy link
Contributor Author

@fhanau fhanau Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Look at build performance with/without this to confirm whether this has an impact

reg add "HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\AppModelUnlock" /t REG_DWORD /f /v "AllowDevelopmentWithoutDevLicense" /d "1"
git config --global core.symlinks true
git config --show-scope --show-origin core.symlinks
git config --system core.longpaths true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ jobs:
image: ${{ matrix.image }}
os_name: ${{ matrix.os-name }}
phase: '-release'
extra_bazel_args: '--strip=always --config=${{matrix.bazel-config}} --config=wpt-report'
extra_bazel_args: '--strip=always --config=${{matrix.bazel-config}} --config=ci-release --config=wpt-report'
arch_name: ${{ matrix.target-arch }}
upload_binary: true
macos_use_lld: true
Expand Down
19 changes: 13 additions & 6 deletions build/ci.bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ build:ci-windows --config=v8-codegen-opt-windows
# LLVM produces a bit more debug info on macOS by default to facilitate debugging with
# LLDB. This is not needed for this use case, so disable it using -fno-standalone-debug –
# this is already the default for Linux/Windows.
build:ci-limit-storage --build_tag_filters=-off-by-default,-requires-container-engine,-workerd-benchmark
build:ci-disable-benchmarks --build_tag_filters=-off-by-default,-requires-container-engine,-workerd-benchmark
test:ci-disable-benchmarks --test_tag_filters=-off-by-default,-requires-fuzzilli,-requires-container-engine,-workerd-benchmark
build:ci-limit-storage --config=ci-disable-benchmarks
build:ci-limit-storage --copt="-g1"
build:ci-limit-storage --copt="-fno-standalone-debug"

Expand All @@ -62,8 +64,8 @@ build:ci-linux-common --copt='-Wno-error=deprecated-declarations'
build:ci-linux-common --action_env=CC=/usr/lib/llvm-19/bin/clang
build:ci-linux-common --host_action_env=CC=/usr/lib/llvm-19/bin/clang

build:ci-linux --config=ci-linux-common --config=ci-limit-storage --remote_download_regex=".*src/workerd/server/workerd.*"
build:ci-linux-arm --config=ci-linux-common --config=ci-limit-storage
build:ci-linux --config=ci-linux-common --remote_download_regex=".*src/workerd/server/workerd.*"
build:ci-linux-arm --config=ci-linux-common

build:ci-linux-debug --config=ci-linux-common --config=ci-limit-storage
build:ci-linux-debug --config=debug --config=rust-debug
Expand All @@ -77,14 +79,14 @@ build:ci-linux-asan --config=asan --copt="-g0" --strip=always
build:ci-linux-arm-asan --config=ci-linux-asan

# Build container tests on Linux CI
test:ci-linux --build_tag_filters=-off-by-default
test:ci-linux-arm --build_tag_filters=-off-by-default
build:ci-linux --build_tag_filters=-off-by-default
build:ci-linux-arm --build_tag_filters=-off-by-default

# Unlike the bazel Unix toolchain the macOS toolchain sets "-O0 -DDEBUG" for fastbuild by
# default. This is unhelpful for compile speeds and test performance, remove the DEBUG
# define.
build:ci-macOS --copt=-UDEBUG
build:ci-macOS --config=ci-limit-storage
test:ci-macOS --config=ci-disable-benchmarks

build:ci-macOS-debug --config=debug

Expand Down Expand Up @@ -116,3 +118,8 @@ common:wpt-report --cache_test_results=no

# Let tests know they're running in CI
test:ci-test --test_env=CI=true

# release CI – disable benchmarks to deal with disk space exhaustion and use remote_download_minimal
# (the workerd binary will always be built/fetched so we can add it to the release artifacts).
build:ci-release --config=ci-disable-benchmarks
build:ci-release --remote_download_minimal --remote_download_regex=".*src/workerd/server/workerd.*"
Loading