-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[CF1] identity-based selectors #24154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Preview URL: https://7ffc1d0a.preview.developers.cloudflare.com Files with changes (up to 15)
|
@@ -133,7 +133,18 @@ To require only one country and one email ending: | |||
|
|||
When you add a rule to your policy, you will be asked to specify the criteria/attributes you want users to meet. These attributes are available for all Access application types, including [SaaS](/cloudflare-one/applications/configure-apps/saas-apps/), [self-hosted](/cloudflare-one/applications/configure-apps/self-hosted-public-app/), and [non-HTTP](/cloudflare-one/applications/non-http/) applications. | |||
|
|||
Identity-based attributes are only checked when a user authenticates to Access. Non-identity attributes are polled continuously, meaning they are-evaluated with each new HTTP request for changes during the [user session](/cloudflare-one/identity/users/session-management/). If you have configured [SCIM provisioning](/cloudflare-one/identity/users/scim/), you can force a user to re-attest all attributes with Access whenever you revoke the user in the IdP or update their IdP group membership. | |||
Identity-based attributes are only checked when a user authenticates to Access. The following selectors are identity-based: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd maybe add a comment about this being an example list of identity based rules. Just because we occasionally add rules and I can almost guarantee we are going to forget to come update this list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this list add anything that is not answered in the table below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jroyal it is implied that if you read 'checked at login' in the table you can deduce that these items are identity-based selectors but we do not explicitly call out our identity based selectors. also 'Everyone' is also checked at login but I do not think that is an identity-based selector?
I can:
- delete the list
- leave the the PR as just deleting the 'IP' bit above
if you think we are good as is. But I would change the word 'attributes' to 'selectors' explicity because we use 'selectors' language in docs and dash and only say attributes here somewhat randomly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everyone is a weird one because its basically just a true
. It always passes. To your point I guess this is clearer, but we will just need to make sure we update it if it changes.
Summary
PCX-18417
Screenshots (optional)
Documentation checklist