Skip to content

Cleanup to follow C-GETTER #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2020

Conversation

slinkydeveloper
Copy link
Member

@slinkydeveloper slinkydeveloper commented Oct 12, 2020

Part of #79. Cleanup to follow the naming convention of getters as proposed by https://rust-lang.github.io/api-guidelines/checklist.html

Also:

  • re-exporting Data in main mod
  • Implemented fmt::Debug in event::Data

Signed-off-by: Francesco Guardiani <[email protected]>
Implemented Debug in event::Data
Exposing event::Data in main cloudevents export
Fixed rebase errors with previous pr

Signed-off-by: Francesco Guardiani <[email protected]>
@slinkydeveloper slinkydeveloper added the enhancement New feature or request label Oct 12, 2020
@slinkydeveloper slinkydeveloper added this to the 0.3 milestone Oct 12, 2020
Signed-off-by: Francesco Guardiani <[email protected]>
@slinkydeveloper slinkydeveloper merged commit c926188 into cloudevents:master Oct 21, 2020
@slinkydeveloper slinkydeveloper deleted the c-getter branch October 21, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant