Fix panic displaying binary data with invalid UTF-8 sequencies #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-araujjo
force-pushed
the
no-panic-display-data
branch
2 times, most recently
from
668b97d to
d2e18df
Compare
Signed-off-by: Gabriel Araújo <[email protected]>
gabriel-araujjo
force-pushed
the
no-panic-display-data
branch
from
d2e18df to
7001945
Compare
lfmatosm
approved these changes
Aug 22, 2024
|
is there a reason this hasnt been merged yet, or is this project dead? |
|
@mfreeman451, the maintainers are very busy, but still around. You can try to get a hold of @Lazzaretti on slack. |
Lazzaretti
reviewed
Jun 26, 2025
There was a problem hiding this comment.
Hi @gabriel-araujjo,
Thanks a lot for your PR 🎉 ...and sorry for my late response.
Is there a way we can remove this unsafe?
Signed-off-by: Gabriel Araújo <[email protected]>
gabriel-araujjo
force-pushed
the
no-panic-display-data
branch
from
0bc783a to
9923d05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #229