Initial dump of Compositions alpha implementation #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
requested review from
matthchr and
a-hilaly
and removed request for
matthchr
|
#8 << user guide dump |
matthchr
reviewed
Nov 5, 2024
| const ( | ||
| Ready ConditionType = "Ready" | ||
| // Error implies the last reconcile attempt failed | ||
| Error ConditionType = "Error" |
There was a problem hiding this comment.
Is the implication that this condition is "fatal", as compared to a situation where Ready=False, but that may mean "we're just not done yet"?
There was a problem hiding this comment.
Error is a catch all for any error (temporary or otherwise) when we reconcile a composition. This may be temporary errors such as unable to reach k8s server, grpc server etc. We have a separate Waiting condition value to indicate we are waiting for something (we are not done yet).
matthchr
approved these changes
Nov 15, 2024
| Type ExpanderType `json:"type"` | ||
|
|
||
| // ExpanderConfig GVK | ||
| Config ExpanderConfigGVK `json:"config"` |
There was a problem hiding this comment.
It is required for helm
There was a problem hiding this comment.
My point I guess is, either it should have kubeuilder:required or it should be json:omitempty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial dump of the Compositions code that we have been demoing in the weekly meetings.
Source: https://github.com/GoogleCloudPlatform/k8s-config-connector/tree/master/experiments/compositions
We want to follow up with commits to: