Fix misuse of second argument as nextState (the actual argument is prevState) #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evState) This fixes instances where, right after scrolling, a change in the `scrollToIndex` prop will not actually scroll to the item at the passed index correctly. This is due to the `componentDidUpdate` method considering the previous state to actually be the next state and looking at `scrollChangeReason` on it, seeing the old `scrollChangeReason` caused by the user scrolling, thus not calling `scrollTo` to actually center the element.
|
Just published this change in |
|
Perfect, thank you very much! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on a horizontal timeline that uses
react-tiny-virtual-listto reduce the amount of items rendered at any one time. Clicking on an item on this timeline should center it horizontally. I noticed that when clicking on an item after scrolling, the item would not center.This fixes instances where, right after scrolling, a change in the
scrollToIndexprop will not actually scroll to the item at the passed index correctly. This is due to thecomponentDidUpdatemethod considering the previous state to actually be the next state and looking atscrollChangeReasonon it, seeing the oldscrollChangeReasoncaused by the user scrolling, thus not callingscrollToto actually center the element.