Skip to content

Remove argument passed to the @destroy event #283

@filipsobol

Description

@filipsobol

The @destroy event has one argument, which was meant to be the editor instance. However, because this instance is removed before the event is fired, the argument is always null.

if ( this.instance ) {
this.instance.destroy();
this.instance = null;
}
// Note: By the time the editor is destroyed (promise resolved, editor#destroy fired)
// the Vue component will not be able to emit any longer. So emitting #destroy a bit earlier.
this.$emit( 'destroy', this.instance );

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions