Skip to content

feat(five): expose unstable profile values as read-only convars #3531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codekrafter
Copy link

Goal of this PR

Expose graphics graphic profile settings through read-only convars, just like every other profile setting. They were excluded in 2021 due to unstable behavior when set to invalid values. This re-introduces them in a read-only state which allows scripts to change behavior based on graphics settings.

How is this PR achieving the goal

Instead of skipping potentially-unstable game profile settings, expose them as read-only. This allows scripts to validate that users have set them to correct values, while eliminating the possibility of setting them to bad values causing a crash.

This PR applies to the following area(s)

FiveM

Successfully tested on

Game builds: 3258

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

N/A

@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs a preliminary assessment to determine the urgency and required action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant