Skip to content

deps: bump mio-rs to 1.1.0#72

Merged
hulxv merged 2 commits intomainfrom
deps/bump-mio
Oct 17, 2025
Merged

deps: bump mio-rs to 1.1.0#72
hulxv merged 2 commits intomainfrom
deps/bump-mio

Conversation

@hulxv
Copy link
Collaborator

@hulxv hulxv commented Oct 17, 2025

Due to fix kevent bug inside mio-rs by tokio-rs/mio#1906. This will fix #68 without implementing a custom wrapper like what happened in #70

Close #68

@hulxv hulxv requested a review from Copilot October 17, 2025 15:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the mio-rs dependency from version 1.0.3 to 1.1.0 to fix a kevent bug, addressing issue #68. The update eliminates the need for a custom event wrapper by directly using mio's Event type.

  • Removed custom Event struct and replaced it with direct usage of mio::event::Event
  • Updated all imports across the codebase to use mio's Event type instead of the custom wrapper
  • Bumped mio dependency version in Cargo.toml to 1.1.0

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/event.rs Removed entire file containing custom Event wrapper struct
src/lib.rs Updated module exports to use mio::event::Event instead of custom Event
src/reactor.rs Updated dispatch_event method to accept mio's Event type directly
src/handler.rs Updated import to use mio::event::Event
src/poll.rs Updated test imports to use mio::event::Event
examples/*.rs Updated all example files to import Event from mio instead of mill_io
Cargo.toml Bumped mio version from 1.0.3 to 1.1.0

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hulxv hulxv merged commit 0edc5ec into main Oct 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Cross-Platform Bug] macOS build fails

2 participants