Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the mio-rs dependency from version 1.0.3 to 1.1.0 to fix a kevent bug, addressing issue #68. The update eliminates the need for a custom event wrapper by directly using mio's Event type.
- Removed custom Event struct and replaced it with direct usage of mio::event::Event
- Updated all imports across the codebase to use mio's Event type instead of the custom wrapper
- Bumped mio dependency version in Cargo.toml to 1.1.0
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/event.rs | Removed entire file containing custom Event wrapper struct |
| src/lib.rs | Updated module exports to use mio::event::Event instead of custom Event |
| src/reactor.rs | Updated dispatch_event method to accept mio's Event type directly |
| src/handler.rs | Updated import to use mio::event::Event |
| src/poll.rs | Updated test imports to use mio::event::Event |
| examples/*.rs | Updated all example files to import Event from mio instead of mill_io |
| Cargo.toml | Bumped mio version from 1.0.3 to 1.1.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to fix kevent bug inside
mio-rsby tokio-rs/mio#1906. This will fix #68 without implementing a custom wrapper like what happened in #70Close #68