Further support for and comply with Compiler Warning Flags

[kashirin-alex]

The Specific Compiler Warning Flags in the Issue:

 -Wcast-align 
 -Wnon-virtual-dtor
 -Wnoexcept
 -Wsuggest-override
 -Wuseless-cast
 -Wold-style-cast
 -Wnull-dereference
 -Wstrict-null-sentinel
 -Wzero-as-null-pointer-constant
 -Wduplicated-branches
 -Wduplicated-cond
 -Wlogical-op

It will be great to know the plans/considerations to fully comply to these warning flags.

The main reason, These additional flags are clearly indicative and at compilation time even if one spot on, it is a long/unclear output to figure-out. (while supposedly as not an actual asio:: programming error)

Other Issues and Pull requests on the subject:
apache/thrift#2318
google/re2#298

Before making the changes required (hopefully all) and requesting a pull. it will be important to know opinions on these specific flags and further more is state of compatibility for platforms/arch other than x86-64(linux/debian) with GCC(9.3-10).

Meanwhile on my project, It is to ignore these flags: (Not an urgent fatal Error/Bug type of an Issue )
https://github.com/kashirin-alex/swc-db/blob/3ac4a1d586435578d57179f36c9777cdd6486a46/src/cc/include/swcdb/core/comm/asio_wrap.h#L12

[kashirin-alex]

An intermediate results for compatibility and state of the warning-flags:
https://github.com/kashirin-alex/asio/runs/1921429875

extended flags 1 (for majority):
https://github.com/kashirin-alex/asio/blob/4ee14d7fa33e41c433ca08e6baa3816047748c0c/.github/workflows/ci.yml#L23

extended flags 2:
https://github.com/kashirin-alex/asio/blob/4ee14d7fa33e41c433ca08e6baa3816047748c0c/.github/workflows/ci.yml#L128

[kashirin-alex]

Should the -Wdeprecated-copy-dtor warning-flag be addressed ? (it is considered a kind of -Weffc++ )

the Produced warnings:
(clang):

asio/ip/bad_address_cast.hpp:39:11: warning: definition of implicit copy constructor for 'bad_address_cast' is deprecated because it has a user-declared destructor [-Wdeprecated-copy-dtor]
  virtual ~bad_address_cast() ASIO_NOEXCEPT_OR_NOTHROW {}
          ^
/home/runner/work/swc-db/swc-db/asio/asio/include/asio/detail/throw_exception.hpp:46:9: note: in implicit copy constructor for 'asio::ip::bad_address_cast' first required here
  throw e;
        ^
/home/runner/work/swc-db/swc-db/asio/asio/include/asio/ip/impl/address_v6.ipp:327:19: note: in instantiation of function template specialization 'asio::detail::throw_exception<asio::ip::bad_address_cast>' requested here
    asio::detail::throw_exception(ex);
                  ^
1 warning generated.

(gcc):

In file included from /home/runner/work/swc-db/swc-db/asio/asio/include/asio/detail/memory.hpp:24,
                 from /home/runner/work/swc-db/swc-db/asio/asio/include/asio/detail/handler_alloc_helpers.hpp:19,
                 from /home/runner/work/swc-db/swc-db/asio/asio/include/asio/detail/executor_function.hpp:19,
                 from /home/runner/work/swc-db/swc-db/asio/asio/include/asio/execution/any_executor.hpp:24,
                 from /home/runner/work/swc-db/swc-db/asio/asio/include/asio/execution.hpp:19,
                 from /home/runner/work/swc-db/swc-db/asio/asio/include/asio/any_completion_executor.hpp:22,
                 from /home/runner/work/swc-db/swc-db/asio/asio/include/asio.hpp:18,
                 from /home/runner/work/swc-db/swc-db/src/cc/include/swcdb/core/comm/asio_wrap.h:34,
                 from /home/runner/work/swc-db/swc-db/src/cc/include/swcdb/core/comm/ConnHandler.h:14,
                 from /home/runner/work/swc-db/swc-db/src/cc/lib/swcdb/fs/Broker/FileSystem.cc:6:
/home/runner/work/swc-db/swc-db/asio/asio/include/asio/detail/throw_exception.hpp: In instantiation of ‘void asio::detail::throw_exception(const Exception&) [with Exception = asio::ip::bad_address_cast]’:
/home/runner/work/swc-db/swc-db/asio/asio/include/asio/ip/impl/address_v6.ipp:327:34:   required from here
/home/runner/work/swc-db/swc-db/asio/asio/include/asio/detail/throw_exception.hpp:46:3: warning: implicitly-declared ‘constexpr asio::ip::bad_address_cast::bad_address_cast(const asio::ip::bad_address_cast&)’ is deprecated [-Wdeprecated-copy-dtor]
   46 |   throw e;
      |   ^~~~~~~
In file included from /home/runner/work/swc-db/swc-db/asio/asio/include/asio/ip/impl/address_v6.ipp:27,
                 from /home/runner/work/swc-db/swc-db/asio/asio/include/asio/ip/address_v6.hpp:413,
                 from /home/runner/work/swc-db/swc-db/asio/asio/include/asio/ip/address.hpp:25,
                 from /home/runner/work/swc-db/swc-db/asio/asio/include/asio.hpp:124,
                 from /home/runner/work/swc-db/swc-db/src/cc/include/swcdb/core/comm/asio_wrap.h:34,
                 from /home/runner/work/swc-db/swc-db/src/cc/include/swcdb/core/comm/ConnHandler.h:14,
                 from /home/runner/work/swc-db/swc-db/src/cc/lib/swcdb/fs/Broker/FileSystem.cc:6:
/home/runner/work/swc-db/swc-db/asio/asio/include/asio/ip/bad_address_cast.hpp:39:11: note: because ‘asio::ip::bad_address_cast’ has user-provided ‘virtual asio::ip::bad_address_cast::~bad_address_cast()’
   39 |   virtual ~bad_address_cast() ASIO_NOEXCEPT_OR_NOTHROW {}
      |           ^

Adjustment can be of-course adding a copy constructor

  bad_address_cast(const bad_address_cast& other) ASIO_NOEXCEPT_OR_NOTHROW: 
#if defined(ASIO_MSVC) && defined(_HAS_EXCEPTIONS) && !_HAS_EXCEPTIONS
      std::exception(other)
#else
      std::bad_cast(other)
#endif
{ }

or a default

bad_address_cast(const bad_address_cast&) ASIO_NOEXCEPT_OR_NOTHROW = default;

at https://github.com/chriskohlhoff/asio/blob/master/asio/include/asio/ip/bad_address_cast.hpp#L36