adjust trait bound for with_clone::Any #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the [new] std::marker::[Reflect] trait made it necessary to specify a Reflect bound, but it's advised to use an Any bound instead. Adding this bound makes it compile. I ran the tests and got an error saying it couldn't determine the type of one of the expressions so I introduced a scope to bind the result of the expression and annotate its type. I also removed the `convert` feature that was no longer needed. [new]: rust-lang/rust#23712 [Reflect]: http://doc.rust-lang.org/std/marker/trait.Reflect.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the new std::marker::Reflect trait made it necessary to
specify a Reflect bound, but it's advised to use an Any bound instead.
Adding this bound makes it compile. I ran the tests and got an error
saying it couldn't determine the type of one of the expressions so I
introduced a scope to bind the result of the expression and annotate its
type.
I also removed the
convertfeature that was no longer needed.