Respect ignoreMissingValueFiles when generating hashes #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up for #31 We were not checking for `ignoreMissingValueFiles` when generating file hashes.
v-yarotsky
commented
Jul 25, 2025
| } | ||
| crd := data[0] | ||
|
|
||
| got, err := GenerateHash(crd, tt.ignoreValueFile) |
There was a problem hiding this comment.
This method was not covered previously
v-yarotsky
commented
Jul 25, 2025
| @@ -219,11 +213,9 @@ func GenerateHash(crd *v1alpha1.Application, ignoreValueFile string) (string, er | |||
| if crd.Spec.Source.Helm != nil && len(crd.Spec.Source.Helm.ValueFiles) > 0 { | |||
| oHash := sha256.New() | |||
| overrideFiles := crd.Spec.Source.Helm.ValueFiles | |||
| matchDots := regexp.MustCompile(`\.\.\/`) | |||
There was a problem hiding this comment.
checking if this will break things, I'm not quite sure what it was trying to achieve
There was a problem hiding this comment.
ok, I've staged hashes for demo/ in git, reverted my changes and reran - no diff, so seems reasonably safe.
mpiercy827
approved these changes
Jul 25, 2025
virtualdom
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #31
We were not checking for
ignoreMissingValueFileswhen generating file hashes.