Skip to content

Monstrous pull request.#2

Closed
nicklasb wants to merge 19 commits intochengz:masterfrom
OptimalBPM:master
Closed

Monstrous pull request.#2
nicklasb wants to merge 19 commits intochengz:masterfrom
OptimalBPM:master

Conversation

@nicklasb
Copy link
Copy Markdown

@nicklasb nicklasb commented Feb 6, 2015

As mentioned in the issue, #1, this has been developed separately.

I understand that this might be a bit much. :-)

Summary:

  • ability to dynamically load the content of the drop downs from any back end.
  • move settings out of the schema and into the form, as having UI-specific settings in a JSON schema isn't that good for portability of the schemas, also some parsers don't accept invalid values of the format attribute.

stevehu and others added 16 commits November 19, 2014 05:44
Form now sends the options structure instead of name, category for greater flexibility
Move StrapSelectController into schema-form-strapselect.js for clarity and as angular wouldn't load script-tags properly from template
Move the controller selection from schema-format into form.item.type
Add callbacks for dropdown content as example
Rename app to testApp

This commit was quite difficult to split as most parts where developed simultaneously, in this case, it wasn't worth the effort.
Conflicts:
	.gitignore
	LICENSE
	README.md
	app.js
	bower.json
	gulpfile.js
	package.json
	src/schema-form-strapselect.js
	test/tests.js
Conflicts:
	.gitignore
	LICENSE
	README.md
	app.js
	bower.json
	gulpfile.js
	package.json
	src/schema-form-strapselect.js
	test/tests.js
@stevehu
Copy link
Copy Markdown

stevehu commented Feb 6, 2015

@nicklasb, nice work. I will test it out and start using it and retire my repo later. Thanks.

@nicklasb
Copy link
Copy Markdown
Author

nicklasb commented Feb 6, 2015

Oh, one more thing is that I removed the connection to angular-translate(and dependency). Perhaps this was important in some way I didn't understand.

I could just as well tell you what I would like to happen next:

  1. Just saw that the static lookup items are stored in the schema, that is also not like I would have it. I would move them as well into the form. That is where the items/titleMap is stored in angular-schema-form anyway. Actually I don't really see what is wrong with using the existing location and making it compatible with the default selects.
  2. Add tests.
  3. Expand the documentation to encompass all functionality.
  4. Perhaps improve upon and add more examples.

Use value, name instead of value, label
Move static lookups from schema.items to form.items
@nicklasb nicklasb closed this Feb 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants