nesting level of some deeply nested tests decreased#1734
Merged
fb55 merged 2 commits intocheeriojs:mainfrom Feb 18, 2021
Merged
nesting level of some deeply nested tests decreased#1734fb55 merged 2 commits intocheeriojs:mainfrom
fb55 merged 2 commits intocheeriojs:mainfrom
Conversation
fb55
reviewed
Feb 14, 2021
Member
|
Nice PR! One comment seems to have been forgotten, otherwise this should be good to go. |
Co-authored-by: Felix Böhm <me@feedic.com>
Member
|
Thanks for following up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.addfunction had some 3rd and 4th level nested tests.