Skip to content

nesting level of some deeply nested tests decreased#1734

Merged
fb55 merged 2 commits intocheeriojs:mainfrom
5saviahv:update-test
Feb 18, 2021
Merged

nesting level of some deeply nested tests decreased#1734
fb55 merged 2 commits intocheeriojs:mainfrom
5saviahv:update-test

Conversation

@5saviahv
Copy link
Copy Markdown
Contributor

.add function had some 3rd and 4th level nested tests.

  • looking from output those indentations are rather subtle and no longer easily readable, I moved them to 2nd level and added argument descriptions used in tests.
  • Also those deeply nested tests aren't very easy to follow in code.
  • no actual change in tests, just formatting.

@fb55
Copy link
Copy Markdown
Member

fb55 commented Feb 14, 2021

Nice PR! One comment seems to have been forgotten, otherwise this should be good to go.

Co-authored-by: Felix Böhm <me@feedic.com>
@fb55 fb55 merged commit 9743030 into cheeriojs:main Feb 18, 2021
@fb55
Copy link
Copy Markdown
Member

fb55 commented Feb 18, 2021

Thanks for following up!

@5saviahv 5saviahv deleted the update-test branch February 25, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants