tests: prefer using .toBeUndefined()#1659
Merged
fb55 merged 2 commits intocheeriojs:mainfrom Jan 9, 2021
XhmikosR:toBeUndefined
Merged
tests: prefer using .toBeUndefined()#1659fb55 merged 2 commits intocheeriojs:mainfrom XhmikosR:toBeUndefined
.toBeUndefined()#1659fb55 merged 2 commits intocheeriojs:mainfrom
XhmikosR:toBeUndefined
Conversation
Member
|
The string value is intended, but wrong. jQuery does stringily values here, but Let's keep the test intact here, and track this in a separate issue? |
Contributor
|
maybe add TODO comment for a test |
Member
|
Great patch, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's one case where tests fail; I added a comment there, but I'm not sure if it's a bug or not.
EDIT: I think it's intended but please confirm so that I revert that part.