attributes: remove unneeded escapes#1635
Merged
fb55 merged 1 commit intocheeriojs:mainfrom Jan 2, 2021
XhmikosR:patch-3
Merged
attributes: remove unneeded escapes#1635fb55 merged 1 commit intocheeriojs:mainfrom XhmikosR:patch-3
fb55 merged 1 commit intocheeriojs:mainfrom
XhmikosR:patch-3
Conversation
fb55
reviewed
Jan 2, 2021
| var rboolean = /^(?:autofocus|autoplay|async|checked|controls|defer|disabled|hidden|loop|multiple|open|readonly|required|scoped|selected)$/i; | ||
| // Matches strings that look like JSON objects or arrays | ||
| var rbrace = /^(?:\{[\w\W]*\}|\[[\w\W]*\])$/; | ||
| var rbrace = /^(?:{[\w\W]*}|\[[\w\W]*])$/; |
Member
There was a problem hiding this comment.
To simplify further, this should be equivalent:
Suggested change
| var rbrace = /^(?:{[\w\W]*}|\[[\w\W]*])$/; | |
| var rbrace = /^(?:{[^]*}|\[[^]*])$/; |
Contributor
Author
There was a problem hiding this comment.
I just split the patch from my xo branch, but feel free to tweak it later. I can't check if your suggestion is fine right now :)
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.