Skip to content

package.json: Add a "bench" alias script#1629

Merged
fb55 merged 1 commit intocheeriojs:mainfrom
XhmikosR:patch-1
Jan 4, 2021
Merged

package.json: Add a "bench" alias script#1629
fb55 merged 1 commit intocheeriojs:mainfrom
XhmikosR:patch-1

Conversation

@XhmikosR
Copy link
Copy Markdown
Contributor

@XhmikosR XhmikosR commented Jan 2, 2021

No description provided.

@fb55
Copy link
Copy Markdown
Member

fb55 commented Jan 2, 2021

I'm not a super big fan of having aliases in the package.json. Should we just rename the original script?

@XhmikosR
Copy link
Copy Markdown
Contributor Author

XhmikosR commented Jan 2, 2021

Your call, but alias help because they work in more cases. Feel free to close the PR, it's just I kept running npm run bench. This should allow both cases to work.

@fb55 fb55 merged commit bb6cb38 into cheeriojs:main Jan 4, 2021
@fb55
Copy link
Copy Markdown
Member

fb55 commented Jan 4, 2021

Decided to merge this, as we don't have insane amounts of scripts at the moment.

@fb55
Copy link
Copy Markdown
Member

fb55 commented Jan 4, 2021

Thanks @XhmikosR!

@XhmikosR XhmikosR deleted the patch-1 branch January 5, 2021 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants