-
Notifications
You must be signed in to change notification settings - Fork 2
Issue #36: Updated CheckstyleAutoFix to load checkstyle-config. #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ee86ef3
to
06f3e1c
Compare
src/main/java/org/checkstyle/autofix/parser/CheckConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/org/checkstyle/autofix/parser/ConfigurationMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/checkstyle/autofix/parser/ConfigurationLoader.java
Outdated
Show resolved
Hide resolved
src/main/java/org/checkstyle/autofix/parser/ConfigurationLoader.java
Outdated
Show resolved
Hide resolved
@rdiachenko |
return children; | ||
} | ||
|
||
public String getProperty(String childName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add more getxxx methods
getIntProperty()
getBooleanProperty()
so that we will hide data type conversion in this class and will avoid having boilerplate code across the codebase
what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timurt
done.
may add other methods later if needed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, let's merge it as it blocks other issues, we will iterate on the logic and improve as part of PRs where we start using it
Fixes: #36
Updated Updated CheckstyleAutoFix to load checkstyle-config.
Implemented property configuration as applied in checkstyle
Main.java
(https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/Main.java#L370).Created
Configuration
Class to store checkstyle configuration.