Remove some and deny new indexing and slicing #1652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One bug found so far: #1650 |
link2xt
force-pushed
the
indexing_slicing
branch
4 times, most recently
from
b2773ca to
27a928e
Compare
link2xt
changed the title
Hocuri
approved these changes
Jul 11, 2020
| @@ -239,6 +239,7 @@ impl MimeMessage { | |||
| /// | |||
| /// Delta Chat sends attachments, such as images, in two-part messages, with the first message | |||
| /// containing an explanation. If such a message is detected, first part can be safely dropped. | |||
| #[allow(clippy::indexing_slicing)] | |||
There was a problem hiding this comment.
Wouldn't it be possible to replace the two parts[0] calls further down with textpart?
There was a problem hiding this comment.
No, borrow checker fails.
link2xt
force-pushed
the
indexing_slicing
branch
from
27a928e to
49ac2ab
Compare
|
I'll merge when tests pass. The goal is not to eliminate all the indexing and slicing we have already. Code we have now is pretty reliable already, but this should prevent addition of new indexing and slicing that may panic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.