fix: handle nested SequenceMsg in event loop and use sync.WaitGroup f…#1463
Merged
aymanbagabas merged 2 commits intomainfrom Aug 8, 2025
Merged
fix: handle nested SequenceMsg in event loop and use sync.WaitGroup f…#1463aymanbagabas merged 2 commits intomainfrom
aymanbagabas merged 2 commits intomainfrom
Conversation
…or BatchMsg This simplifies the handling of nested BatchMsg within sequenceMsg and ensures that all commands in a BatchMsg are executed before proceeding. It also replaces errgroup with sync.WaitGroup for better clarity and performance when waiting for multiple goroutines to finish. Fixes: #680 Supersedes: #843
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1463 +/- ##
==========================================
- Coverage 70.22% 69.04% -1.19%
==========================================
Files 17 17
Lines 1733 1741 +8
==========================================
- Hits 1217 1202 -15
- Misses 468 485 +17
- Partials 48 54 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
meowgorithm
approved these changes
Aug 8, 2025
meowgorithm
added a commit
to charmbracelet/crush
that referenced
this pull request
Aug 8, 2025
meowgorithm
added a commit
to charmbracelet/crush
that referenced
this pull request
Aug 8, 2025
aymanbagabas
added a commit
that referenced
this pull request
Aug 15, 2025
The commands channel handler handles commands and their execution. We should not execute them ourself in the event loop and instead send them to the commands channel where the handles will take care of executing them. Fixes: f5da8d0 (fix: handle nested SequenceMsg in event loop and use sync.WaitGroup f… (#1463))
aymanbagabas
added a commit
that referenced
this pull request
Aug 15, 2025
The commands channel handler handles commands and their execution. We should not execute them ourself in the event loop and instead send them to the commands channel where the handles will take care of executing them. Fixes: f5da8d0 (fix: handle nested SequenceMsg in event loop and use sync.WaitGroup f… (#1463))
scalabl3
pushed a commit
to metaphori-ai/crush
that referenced
this pull request
Aug 19, 2025
aymanbagabas
added a commit
that referenced
this pull request
Sep 8, 2025
… event loop (#1473) We shouldn't execute commands in the event loop ourselves. Instead, we should send them to the commands channel where the command handlers will take care of executing them. Fixes: f5da8d0 (fix: handle nested SequenceMsg in event loop and use sync.WaitGroup f… (#1463)) Supersedes: #1485
OHANA-WEB
added a commit
to OHANA-WEB/crush
that referenced
this pull request
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…or BatchMsg
This simplifies the handling of nested BatchMsg within sequenceMsg and ensures that all commands in a BatchMsg are executed before proceeding. It also replaces errgroup with sync.WaitGroup for better clarity and performance when waiting for multiple goroutines to finish.
Fixes: #680
Supersedes: #843