🐛 fix duplicate switch ports #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When iterating through devices, switch ports were being accumulated across the devices. Only the first device actually had the correct complement of ports, with subsequent devices having their own, plus the previous device’s ports. Unclear if this is the actual problem c48cd4d was trying to address, or different scenario I don’t see in my environment, so I left it in.
charlie-haley
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When iterating through devices, switch ports were being accumulated across the devices. Only the first device actually had the correct complement of ports, with subsequent devices having their own, plus the previous device’s ports.
Unclear if this is the actual problem c48cd4d was trying to address, or different scenario I don’t see in my environment, so I left it in.