Skip to content

feat: Update SABER deposition to include authors, more data, instance segmentation masks. #614

Open
uermel wants to merge 5 commits intomainfrom
uermel/update_saber
Open

feat: Update SABER deposition to include authors, more data, instance segmentation masks. #614
uermel wants to merge 5 commits intomainfrom
uermel/update_saber

Conversation

@uermel
Copy link
Contributor

@uermel uermel commented Mar 9, 2026

Updating SABER-depostion to:

  • include authors
  • include now available instance segmentations
  • include annotations for more datasets

Copy link
Contributor

@daniel-ji daniel-ji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I've suggested some changes.

In general, should annotation dates (or at least the last_modified dates) get updated? Thanks!

annotation_object:
id: GO:0016234
name: inclusion body
annotation_software: SABER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

annotation software should be nnInteractive? i.e. annotation_software: nnInteractive

annotation_object:
id: GO:0016234
name: inclusion body
annotation_software: SABER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as the comment above - annotation software should be nnInteractive? i.e. annotation_software: nnInteractive

method_type: hybrid
version: 1.0
sources:
- SemanticSegmentationMask:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be InstanceSegmentationMask? Above is also SemanticSegmentationMask with the same glob_string

an expert-in-the-loop approach to refine segmentations based on the embedding
space of SAM2. Segmentations are provided as semantic masks, with a point at
the center of mask indicating object instances. Authors are redacted pending
peer review process.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authors are redacted pending peer review process.

Should this be removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And in general, update the deposition description to add the new annotations, mention nnInteractive, and change the "center of mask indicating object instances" to instance segmentation masks?

For example:

deposition_description: This deposition contains segmentations of whole cells,
  inclusion bodies, virus-like particles, and components of bacterial cells and
  microsporidia. The segmentations were generated using the SABER package,
  which is a SAM2-based segmentation framework that uses an
  expert-in-the-loop approach to refine segmentations based on the embedding
  space of SAM2, and with nnInteractive for semi-manual annotation.
  Segmentations are provided as semantic masks and instance segmentation
  masks.

# parent_filters:
# include:
# dataset:
# - '10442'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still a work in progress? Or should these comments be removed?

file_format: zarr
glob_string: '{dataset_name}/overlay/ExperimentRuns/{run_name}/Segmentations/10.000_SABER_1_minicell-multilabel.zarr'
glob_string: '{dataset_name}/overlay/ExperimentRuns/{run_name}/Segmentations/*_saber_1_virus-multilabel.zarr'
is_visualization_default: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be false (following a similar pattern as the other semantic seg + instance seg pairs)?

@daniel-ji daniel-ji requested review from daniel-ji and removed request for daniel-ji March 14, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants