remove invalid assert for jit page state #1677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-bot test Ubuntu ubuntu_linux_release_static |
|
LGTM to me although if the assert was moved within the lock, would it then be legitimate? |
|
@digitalinfinity there actually already is an assert for this inside the lock. |
|
Ah excellent- thanks for checking! |
chakrabot
pushed a commit
that referenced
this pull request
Oct 3, 2016
Merge pull request #1677 from MikeHolman:executeassert This assert is outside the lock, so if another JIT is happening at same time, the page can become read/write/execute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assert is outside the lock, so if another JIT is happening at same time, the page can become read/write/execute