Skip to content

fix xProc number allocator #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2016
Merged

fix xProc number allocator #1635

merged 2 commits into from
Sep 27, 2016

Conversation

leirocks
Copy link
Contributor

@leirocks leirocks commented Sep 23, 2016 •
edited
Loading

  • some fix needed because of the IDL adjustment(numberSegment changing to pointer and Arena allocated)
  • delay allocate the segment only when necessary(when there's number need to be allocated in JIT time)
  • added test switch to make the integration and segment full code path easier to test in oop JIT (currently 0x20 pages hold 0x2000 numbers which is extremely hard to fullfil the segment)
  • make recycler memory verify work for cross process number allocator

@leirocks
fix xProc number allocator
0106510 
some fix needed because of the IDL adjustment(numberSegment changing to pointer and Arena allocated)
delay allocate the segment only when necessary(when there's number need to be allocated in JIT time)
added test switch to make the integration and segment full code path easier to test in oop JIT (currently 0x20 pages hold 0x2000 numbers which is extremely hard to fullfil the segment)
make recycler memory verify work for cross process number allocator
@MikeHolman
Copy link
Contributor

MikeHolman commented Sep 26, 2016 •
edited by leirocks
Loading 

                        this->topFunc->GetNumberAllocator(),

can you have ifdef only for this line? #ByDesign

Refers to: lib/Backend/Inline.cpp:1190 in ecfe189. [](commit_id = ecfe189, deletion_comment = False)

@leirocks
Copy link
Contributor Author 

                        this->topFunc->GetNumberAllocator(),

No, this is in a Macro (JitAnew), '#if' will be treated as a Macro input argument

In reply to: 249614624 [](ancestors = 249614624)

Refers to: lib/Backend/Inline.cpp:1190 in ecfe189. [](commit_id = ecfe189, deletion_comment = False)

@MikeHolman
Copy link
Contributor

:shipit:

@chakrabot chakrabot merged commit ecfe189 into chakra-core:master Sep 27, 2016
chakrabot pushed a commit that referenced this pull request Sep 27, 2016
@leirocks
[MERGE #1635 @leirocks] fix xProc number allocator
d07045f 
Merge pull request #1635 from leirocks:xprocnumber

- some fix needed because of the IDL adjustment(numberSegment changing to pointer and Arena allocated)
- delay allocate the segment only when necessary(when there's number need to be allocated in JIT time)
- added test switch to make the integration and segment full code path easier to test in oop JIT (currently 0x20 pages hold 0x2000 numbers which is extremely hard to fullfil the segment)
- make recycler memory verify work for cross process number allocator
@snyk-bot snyk-bot mentioned this pull request Nov 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MikeHolman MikeHolman

@curtisman curtisman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leirocks @MikeHolman @msftclas @curtisman @chakrabot