Add support for Visual Studio 15 Preview 4 #1553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@curtisman or @digitalinfinity please review |
|
Do we have problem compiling using v150 toolset? |
|
__declspec(guard(overflow)) doesn't seem to work when I retarget, and it seems to retarget to v140 anyway. I don't see v150 installed. I didn't spend much time looking. |
| @@ -12,6 +12,7 @@ | |||
| <PlatformToolset Condition="'$(VisualStudioVersion)'=='11.0'">v110</PlatformToolset> | |||
| <PlatformToolset Condition="'$(VisualStudioVersion)'=='12.0'">v120</PlatformToolset> | |||
| <PlatformToolset Condition="'$(VisualStudioVersion)'=='14.0'">v140</PlatformToolset> | |||
| <PlatformToolset Condition="'$(VisualStudioVersion)'=='15.0'">v140</PlatformToolset> | |||
There was a problem hiding this comment.
Maybe add a comment explaining why it doesn't match?
|
Ping. New projects in 15 Preview 4 use v140. |
|
@tcare I still favor adding a comment to point out that the |
…io 2015 platform toolset for now, this will just allow us to use the IDE without it complaining.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll use the Visual Studio 2015 platform toolset for now, this will just allow us to use the IDE without it complaining.