-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Extend test timeout for allocation*.js and array_slice.js which can run longer on busy or low-resource test VMs. #1421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FYI @ianwjhalliday |
…un longer on busy or low-resource test VMs. We've observed them run for around 120 seconds; increasing the timeout to 300 seconds (5 minutes) should more than account for this. Fixes chakra-core#1406 and chakra-core#1417
@dotnet-bot test Windows x86_test please |
@obastemur primarily because there is a lack of consensus on moving them to slow-running tests. We need to fix what's broken. If we decide to move them to slow, we can do that later. Also even if we mark them as slow, they still need to have a large enough timeout. Slow is just a test run configuration, and doesn't exclude the tests from the timeout. Also the reason I picked 300 is because it is long enough to solve the problems and it matches the other non-default timeouts set for long-running tests:
|
LGTM |
Thanks @obastemur. I'm merging this in and hopefully this will unblock all of our PRs and other affected build configurations. |
We've observed them run for around 120 seconds; increasing the timeout to 300 seconds (5 minutes) should more than account for this.
Fixes #1406
Fixes #1417