Fix !== codegen for arm when destination operand is same as both source operands #1411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @meg-gupta, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
|
@satheeshravi Can you please review ? |
|
@dotnet-bot : can you please test windows arm_release ? |
|
|
meg-gupta
force-pushed
the
fixarmstrictneq
branch
from
f459110 to
e9c5d6c
Compare
|
@dotnet-bot Please test windows x86_release |
chakrabot
pushed a commit
that referenced
this pull request
Aug 10, 2016
…rand is same as both source operands Merge pull request #1411 from meg-gupta:fixarmstrictneq When destination of CmpSrNeq_A is same as both its sources, we need to generate instructions that saves the value of both the sources in newly created Opnds. Current codegen did not check the case when destination can be equal to both the sources. This change fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When destination of CmpSrNeq_A is same as both its sources, we need to generate instructions that saves the value of both the sources in newly created Opnds.
Current codegen did not check the case when destination can be equal to both the sources. This change fixes it.