Skip to content

Fix build break in VS2013 #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2016
Merged

Conversation

digitalinfinity
Copy link
Contributor

Disable a warning in VS2013 in Utf8Codex.cpp (it's disabled through the rest of the project anyway, but Codex doesn't use the header that disables those warnings so explicitly disable for Utf8Codex too)

@digitalinfinity
Copy link
Contributor Author

@dotnet-bot test Windows arm_test please

@digitalinfinity
Copy link
Contributor Author

@curtisman @dilijev please review

@dilijev
Copy link
Contributor

dilijev commented Aug 8, 2016

LGTM :shipit:

@dilijev
Copy link
Contributor

dilijev commented Aug 8, 2016

@dotnet-bot test legacy tests please

@chakrabot chakrabot merged commit e9f1475 into chakra-core:master Aug 9, 2016
chakrabot pushed a commit that referenced this pull request Aug 9, 2016
Merge pull request #1404 from digitalinfinity:warning_fix

Disable a warning in VS2013 in Utf8Codex.cpp (it's disabled through the rest of the project anyway, but Codex doesn't use the header that disables those warnings so explicitly disable for Utf8Codex too)
@digitalinfinity digitalinfinity deleted the warning_fix branch August 9, 2016 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants