Check fast path of Math.pow in interpreter to make the result consistent with JIT code #1396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent with JIT code
|
@rajatd could you please review? |
| @@ -293,6 +294,11 @@ namespace Js | |||
| // pow([+/-] 1, Infinity) = NaN according to javascript, but not for CRT pow. | |||
| return JavascriptNumber::NaN; | |||
| } | |||
| else if (TryGetInt32Value(y, &intY)) | |||
There was a problem hiding this comment.
Run the benchmarks just to be sure. #Resolved
There was a problem hiding this comment.
Thanks. Just run though Octane, Kraken and SunSpider again last build from master. No regression detected.
In reply to: 73776762 [](ancestors = 73776762)
|
|
|
@dotnet-bot test Ubuntu ubuntu_linux_release_static |
|
@dotnet-bot test this please. |
chakrabot
pushed a commit
that referenced
this pull request
Aug 8, 2016
…to make the result consistent with JIT code Merge pull request #1396 from ThomsonTan:FixMathPowInconsistency Interpreter always go to slow path of Math.pow because the perf win is not substantial in interpreter, and but could give more accurate float point result. This leads to result inconsistency between JIT code and interpreter. This fix checks fast path in interpreter to make the result consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interpreter always go to slow path of Math.pow because the perf win is not substantial in interpreter, and but could give more accurate float point result. This leads to result inconsistency between JIT code and interpreter. This fix checks fast path in interpreter to make the result consistent.