Fix for StrictMode with args optimization #1322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pleath : Can you please take a look ? |
|
|
Dictionary type is not shareable with the current design and hence cannot be cached on the javascript library. We can change this design if there is a compelling reason in the future. For now, Creating dictionary type everytime still works better than what we had before.
satheeshravi
force-pushed
the
StrictMode_BugFix
branch
from
2e93306 to
a68ef64
Compare
chakrabot
pushed a commit
that referenced
this pull request
Jul 23, 2016
Merge pull request #1322 from satheeshravi:StrictMode_BugFix Dictionary type is not shareable with the current design and hence cannot be cached on the javascript library. We can change this design if there is a compelling reason in the future. For now, Creating dictionary type everytime still works better than what we had before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dictionary type is not shareable with the current design and hence cannot be cached on the javascript library.
We can change this design if there is a compelling reason in the future.
For now, Creating dictionary type everytime still works better than what we had before.