OS X, many CSSM_* errors

[Fishrock123]

These appear on OS X 10.10.5

error: 'CSSM_GUID' is deprecated: first deprecated in OS X 10.7 [-Werror,-Wdeprecated-declarations]

error: 'CSSM_LIST' is deprecated: first deprecated in OS X 10.7 [-Werror,-Wdeprecated-declarations]

error: 'CSSM_SAMPLE' is deprecated: first deprecated in OS X 10.7 [-Werror,-Wdeprecated-declarations]

error: 'CSSM_DATA' is deprecated: first deprecated in OS X 10.7 [-Werror,-Wdeprecated-declarations]

[obastemur]

Looks like we have -Wno-deprecated-declarations flag is set for Windows, however we don't have it on CMAKE.

Since I'm unable to reproduce the problem, could you please try adding that flag into https://github.com/Microsoft/ChakraCore/blob/master/CMakeLists.txt#L127-L128 ?

[Fishrock123]

@obastemur That appears to turn them into warning and the compilation gets further.

e.g.

warning: 'CSSM_TP_AUTHORITY_ID' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]

---

Now I'm getting this:

/Users/Jeremiah/Documents/ChakraCore/pal/src/synchmgr/synchmanager.cpp:4348:42: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
        if (((&m_leOwnedObjsList)->Flink == (&m_leOwnedObjsList)))
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
/Users/Jeremiah/Documents/ChakraCore/pal/src/synchmgr/synchmanager.cpp:4348:42: note: remove extraneous parentheses around the comparison to silence this warning
        if (((&m_leOwnedObjsList)->Flink == (&m_leOwnedObjsList)))
            ~                            ^                      ~
/Users/Jeremiah/Documents/ChakraCore/pal/src/synchmgr/synchmanager.cpp:4348:42: note: use '=' to turn this equality comparison into an assignment
        if (((&m_leOwnedObjsList)->Flink == (&m_leOwnedObjsList)))
                                         ^~
                                         =

I'll try turning on -Wparentheses-equality too.

[Fishrock123]

Hmm, -Wparentheses-equality didn't seem to fix the second error, any suggestions?

[obastemur]

How about '-Wno-parentheses-equality' ?

[Fishrock123]

That works.

I would PR this but I'm unlikely to figure out my CLA situation over the weekend, you may as well do it. :/

[obastemur]

IMO this can wait couple of days and hoping to see your PR. Thanks for the effort!