Add exception for php_image_include rule #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
eslerm
approved these changes
Jun 12, 2025
| condition: | ||
| filesize < 5242880 and all of them | ||
| filesize < 5242880 and all of them and none of ($not*) |
There was a problem hiding this comment.
I've felt like I should ask this about other false positive mitigations we've been putting in place, but should the logic here be instead:
and not all of $(not*) as in, ignore if all the exception rules are matched rather than any one of them?
(I can open this as a separate issue if we'd like to discuss this as a general project principle.)
There was a problem hiding this comment.
I've been thinking about that. We can workshop this 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a straightforward exception for the embedding of Symfony's favicon as base64 in the
php_image_includerule.