Skip to content

Fix CI errors due to pyglet, zipp, mock, and gym#592

Merged
toslunar merged 9 commits intochainer:masterfrom
muupan:fix-ci-v0.8.0
Feb 13, 2020
Merged

Fix CI errors due to pyglet, zipp, mock, and gym#592
toslunar merged 9 commits intochainer:masterfrom
muupan:fix-ci-v0.8.0

Conversation

@muupan
Copy link
Copy Markdown
Member

@muupan muupan commented Feb 12, 2020

  • Use newer gym because old gym does not work with pyglet>=1.4.
  • Modify some example scripts that are not compatible with newer gym.
  • Use zipp==1.0.0 in flexCI because new zipp does not work with Python 3.5.
  • Remove mock from dependency as we do not support py2 now.

because newer versions won't work with python 3.5.
@muupan
Copy link
Copy Markdown
Member Author

muupan commented Feb 12, 2020

/test

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit 890f858:

@muupan
Copy link
Copy Markdown
Member Author

muupan commented Feb 12, 2020

/test

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit 65534f0:

Copy link
Copy Markdown
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar
Copy link
Copy Markdown
Member

https://travis-ci.org/chainer/chainerrl/jobs/649363317#L2503

$ ./test_examples.sh -1
Running example tests: examples_tests/atlas/test_soft_actor_critic.sh
Output files are saved in /tmp/tmp.cdt7eztf9w/atlas/soft_actor_critic/20200212T100236.429911
/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/gym/logger.py:30: UserWarning: WARN: Box bound precision lowered by casting to float32
  warnings.warn(colorize('%s: %s'%('WARN', msg % args), 'yellow'))
Traceback (most recent call last):
  File "examples/atlas/train_soft_actor_critic_atlas.py", line 243, in <module>
    main()
  File "examples/atlas/train_soft_actor_critic_atlas.py", line 123, in main
    timestep_limit = sample_env.spec.tags.get(
AttributeError: 'EnvSpec' object has no attribute 'tags'
The command "./test_examples.sh -1" exited with 1.

due to the version of gym?

@pfn-ci-bot

This comment has been minimized.

@muupan
Copy link
Copy Markdown
Member Author

muupan commented Feb 12, 2020

/test

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit 73a1a44:

@muupan muupan changed the title Fix CI errors due to pyglet and zipp Fix CI errors due to pyglet, zipp, mock, and gym Feb 12, 2020
@muupan
Copy link
Copy Markdown
Member Author

muupan commented Feb 12, 2020

/test

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit 7fb7212:

@muupan muupan added the test label Feb 12, 2020
@muupan muupan added this to the v0.8 milestone Feb 12, 2020
@muupan
Copy link
Copy Markdown
Member Author

muupan commented Feb 12, 2020

/test

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit 54b49c9:

@muupan muupan marked this pull request as ready for review February 12, 2020 12:23
@muupan
Copy link
Copy Markdown
Member Author

muupan commented Feb 12, 2020

@toslunar I added changes to fix errors caused by gym==0.16.0. Now CI is all ok. Can you check the additional changes and merge if it's ok?

@muupan muupan requested a review from toslunar February 12, 2020 12:25
@toslunar toslunar self-assigned this Feb 13, 2020
@toslunar
Copy link
Copy Markdown
Member

I confirmed env.spec.max_episode_steps is available with gym 0.9.7, the minimum requirement by ChainerRL.

Copy link
Copy Markdown
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar toslunar merged commit f8d45d9 into chainer:master Feb 13, 2020
@muupan muupan deleted the fix-ci-v0.8.0 branch February 13, 2020 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants