Skip to content

Add documentation for Q-functions and some missing details in docstrings#556

Merged
toslunar merged 3 commits intochainer:masterfrom
marioyc:q_functions_docs
Oct 1, 2019
Merged

Add documentation for Q-functions and some missing details in docstrings#556
toslunar merged 3 commits intochainer:masterfrom
marioyc:q_functions_docs

Conversation

@marioyc
Copy link
Copy Markdown
Contributor

@marioyc marioyc commented Sep 18, 2019

No description provided.

@marioyc
Copy link
Copy Markdown
Contributor Author

marioyc commented Sep 18, 2019

/test

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit 8fcb688:

chainer.Chain, StateQFunction):
"""Fully-connected state-input continuous Q-function.

See: http://arxiv.org/abs/1603.00748
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https looks better to me.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@abstractmethod
def __call__(self, x, a):
"""Evaluates Q-function

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add Args: section?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@marioyc
Copy link
Copy Markdown
Contributor Author

marioyc commented Sep 18, 2019

/test

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit 98714d1:

@toslunar toslunar self-requested a review October 1, 2019 09:45
@toslunar toslunar self-assigned this Oct 1, 2019
Copy link
Copy Markdown
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar toslunar merged commit d9036b5 into chainer:master Oct 1, 2019
@muupan muupan added this to the v0.8 milestone Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants