Improve parameter distributions used in TestGaussianDistribution#540
Merged
muupan merged 3 commits intochainer:masterfrom Aug 26, 2019
Merged
Improve parameter distributions used in TestGaussianDistribution#540muupan merged 3 commits intochainer:masterfrom
muupan merged 3 commits intochainer:masterfrom
Conversation
Member
Author
|
/test |
Collaborator
|
Successfully created a job for commit c91d7cc: |
toslunar
approved these changes
Aug 26, 2019
Member
Author
|
/test |
Collaborator
|
Successfully created a job for commit d62fe4c: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, both mean and var is sampled uniformly from [0,1]. This is not good because
This PR changes the parameter distributions so that mean is sampled from N(0,1) while variance is sampled from U(0.5,2).
I locally ran TestGaussian 100 times without failure.