Skip to content

Use Link.cleargrads instead of Link.zerograds in REINFORCE #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muupan merged 3 commits into from
Sep 17, 2019
Merged

Use Link.cleargrads instead of Link.zerograds in REINFORCE #536

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
640ea0d
Use Link.cleargrads instead of Link.zerograds
muupan Aug 25, 2019
2a42ad0
Merge branch 'master' into reinforce-cleargrads
muupan Aug 26, 2019
101473e
Merge branch 'master' into reinforce-cleargrads
muupan Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions chainerrl/agents/reinforce.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def stop_episode_and_train(self, obs, reward, done=False):

def accumulate_grad(self):
if self.n_backward == 0:
self.model.zerograds()
self.model.cleargrads()
# Compute losses
losses = []
for r_seq, log_prob_seq, ent_seq in zip(self.reward_sequences,
Expand Down Expand Up @@ -168,7 +168,7 @@ def batch_update(self):
assert len(self.log_prob_sequences) == self.batchsize
assert len(self.entropy_sequences) == self.batchsize
# Update the model
self.model.zerograds()
assert self.n_backward == 0
self.accumulate_grad()
self.optimizer.update()
self.n_backward = 0
Expand Down