Add a deterministic mode to IQN for stable tests#529
Merged
muupan merged 6 commits intochainer:masterfrom Sep 17, 2019
Merged
Conversation
…next-action-error' into iqn-act-deterministically
muupan
changed the title
Member
Author
|
/test |
Collaborator
|
Successfully created a job for commit 2fe1139: |
Member
Author
|
/test |
Collaborator
|
Successfully created a job for commit 5647606: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge #528 before this PR.Resolves #522
This PR adds an optional deterministic mode to IQN that makes it to use a deterministic, equally-spaced sequence of numbers as quantile thresholds for evaluation. This prevents IQN and DoubleIQN's slow tests from randomly failing.
Below is the results of running
pytest10 times (including slow and gpu tests) and counting number of full successes.Before this PR:
pytest -xsv tests/agents_tests/test_iqn.py: 4/10pytest -xsv tests/agents_tests/test_double_iqn.py: 3/10After this PR:
pytest -xsv tests/agents_tests/test_iqn.py: 10/10pytest -xsv tests/agents_tests/test_double_iqn.py: 10/10