Skip to content

Split test_examples.sh#472

Merged
muupan merged 1 commit intochainer:masterfrom
muupan:split-test-examples
Jun 12, 2019
Merged

Split test_examples.sh#472
muupan merged 1 commit intochainer:masterfrom
muupan:split-test-examples

Conversation

@muupan
Copy link
Copy Markdown
Member

@muupan muupan commented Jun 8, 2019

This PR splits test_examples.sh to multiple files so that each example script has a corresponding test script. This change allows executing tests for a single example script separately and avoiding unnecessary conflicts due to modifying test_examples.sh at the same time.

Copy link
Copy Markdown
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python examples/mujoco/td3/train_td3.py --env Pendulum-v0 --gpu $gpu --steps 10 --replay-start-size 5 --batch-size 5 --outdir $outdir/mujoco/td3
model=$(find $outdir/mujoco/td3 -name "*_finish")
python examples/mujoco/td3/train_td3.py --env Pendulum-v0 --demo --load $model --eval-n-runs 1 --outdir $outdir/temp --gpu $gpu
for SCRIPT in $(find examples_tests/ -type f -name '*.sh')
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for SCRIPT in $(find examples_tests/ -type f -name '*.sh')
for SCRIPT in $(find examples_tests/ -type f -name 'test_*.sh')

if non-test scripts will be added under the directory.

@muupan muupan merged commit 19c5c8d into chainer:master Jun 12, 2019
@muupan muupan added this to the v0.7 milestone Jun 28, 2019
@muupan muupan added test and removed test labels Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants