Skip to content

Make IQN work with tuple observations#435

Merged
muupan merged 1 commit intochainer:masterfrom
muupan:iqn-tuple-obs
Apr 5, 2019
Merged

Make IQN work with tuple observations#435
muupan merged 1 commit intochainer:masterfrom
muupan:iqn-tuple-obs

Conversation

@muupan
Copy link
Copy Markdown
Member

@muupan muupan commented Apr 5, 2019

batch_next_state may not be an ndarray, e.g., when observations are tuples of ndarrays. To avoid an error caused by this, use exp_batch['reward'] to get the batch size since it is always an ndarray

Copy link
Copy Markdown
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muupan muupan merged commit e6e47d3 into chainer:master Apr 5, 2019
@muupan muupan deleted the iqn-tuple-obs branch April 5, 2019 11:35
@muupan muupan added this to the v0.7 milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants