Skip to content

Drop hacking#381

Merged
toslunar merged 5 commits intochainer:masterfrom
muupan:drop-hacking
Jan 16, 2019
Merged

Drop hacking#381
toslunar merged 5 commits intochainer:masterfrom
muupan:drop-hacking

Conversation

@muupan
Copy link
Copy Markdown
Member

@muupan muupan commented Jan 9, 2019

Currently, pipenv install -r requirements-dev.txt fails due to version inconsistency of pycodestyle caused by hacking:

  • autopep8==1.4.3 requires pycodestyle>=2.4.0
  • hacking==1.1.0 requires flake8<2.7.0,>=2.6.0
  • flake8==2.6.2 requires pycodestyle<2.1,>=2.0

This PR drops hacking so we use flake8 instead.

Chainer already dropped hacking chainer/chainer#4864

@muupan muupan changed the title Drop hacking [WIP] Drop hacking Jan 9, 2019
@muupan muupan changed the title [WIP] Drop hacking Drop hacking Jan 9, 2019
@muupan muupan requested a review from toslunar January 9, 2019 07:27
toslunar
toslunar approved these changes Jan 16, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar toslunar added the test label Jan 16, 2019
@toslunar toslunar self-assigned this Jan 16, 2019
@toslunar toslunar added this to the v0.6 milestone Jan 16, 2019
@toslunar toslunar merged commit 7163952 into chainer:master Jan 16, 2019
@muupan muupan modified the milestone: v0.6 Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toslunar toslunar toslunar approved these changes

Assignees

@toslunar toslunar

Labels

test

Projects

None yet

Milestone

v0.6

Development

Successfully merging this pull request may close these issues.

2 participants

@muupan @toslunar