make ReplayBuffer.load() compatible with v0.2.0.#216
Merged
toslunar merged 3 commits intochainer:masterfrom Jan 18, 2018
Merged
make ReplayBuffer.load() compatible with v0.2.0.#216toslunar merged 3 commits intochainer:masterfrom
toslunar merged 3 commits intochainer:masterfrom
Conversation
mr4msm
changed the title
toslunar
reviewed
Jan 17, 2018
Member
toslunar
left a comment
toslunar
left a comment
There was a problem hiding this comment.
Thanks for the PR.
LGTM except for the detection of v0.2 buffers. Let me fix it before merging.
chainerrl/replay_buffer.py
Outdated
| def load(self, filename): | ||
| with open(filename, 'rb') as f: | ||
| self.memory = pickle.load(f) | ||
| if not isinstance(self.memory, RandomAccessQueue): |
Member
There was a problem hiding this comment.
PrioritizedReplayBuffer.load doesn't work well, because the class extends ReplayBuffer and its memory is not RandomAccessQueue.
Contributor
Author
There was a problem hiding this comment.
Thanks for your comment.
Sorry, I completely forgot to consider prioritized buffers.
Contributor
Author
|
I appreciate your comment, additional commit and PR #217. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we use ReplayBuffer that loaded a buffer saved with v0.2.0, an error will occur because deque doesn't have sample() method.
This PR makes load() methods of ReplayBuffer and EpisodicReplayBuffer compatible with buffer saved with v0.2.0.