Improve StateActionQFunctions#172
Merged
toslunar merged 11 commits intochainer:masterfrom Nov 16, 2017
Merged
Conversation
muupan
changed the title
muupan
changed the title
toslunar
requested changes
Nov 15, 2017
Member
toslunar
left a comment
toslunar
left a comment
There was a problem hiding this comment.
Thanks. I left a few minor comments.
| Nonlinearities with learnable parameters such as PReLU are not | ||
| supported. | ||
| last_wscale (float): Scale of weight initialization of the last layer. | ||
|
|
Member
There was a problem hiding this comment.
This empty line seems unnecessary.
| self.nonlinearity = nonlinearity | ||
|
|
||
| super().__init__() | ||
| with self.init_scope(): |
Member
There was a problem hiding this comment.
Could you add a comment that nonlinearity does not need to be passed to MLPBN because hidden_sizes is empty?
| *testing.product({ | ||
| 'n_dim_obs': [1, 5], | ||
| 'n_dim_action': [1, 3], | ||
| 'n_hidden_layers': [0, 1, 2], |
Member
Author
There was a problem hiding this comment.
n_hidden_layers=0 works except for LateAction architectures. I'll remove 0 for them.
Member
Author
|
Thank you for your review! I fixed the points you mentioned. |
toslunar
approved these changes
Nov 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please merge this after merging #171
nonlinearityandlast_wscalearuguments to StateActionQFunctions