-
Notifications
You must be signed in to change notification settings - Fork 189
ENT-8118: Added os_version_minor sys variable #5777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Marking this PR as stale due to inactivity; it will be closed in 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚀 Would be nice if you could add an acceptance test. You can use os_version_major.cf as inspiration.
e9cb703
to
e57cbe7
Compare
b01c5ad
to
77e6a40
Compare
77e6a40
to
d7df578
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you will have to derive os_version_minor
from somewhere else on Windows. We don't want it to be "Unknown"
on supported platforms.
d7df578
to
dcc3edc
Compare
@cf-bottom jenkins, please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/12226/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12226/ |
Build for Windows (no tests) |
Ticket: ENT-8118 Changelog: Title Signed-off-by: Victor Moene <[email protected]>
Signed-off-by: Victor Moene <[email protected]>
dcc3edc
to
6001b97
Compare
No description provided.