Skip to content

ENT-8118: Added os_version_minor sys variable #5777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

victormlg
Copy link
Contributor

No description provided.

Copy link

Marking this PR as stale due to inactivity; it will be closed in 7 days.

@github-actions github-actions bot added the stale Pull requests with no recent activity label May 26, 2025
Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀 Would be nice if you could add an acceptance test. You can use os_version_major.cf as inspiration.

@github-actions github-actions bot removed the stale Pull requests with no recent activity label May 27, 2025
@victormlg victormlg force-pushed the os_version_minor branch 2 times, most recently from b01c5ad to 77e6a40 Compare June 10, 2025 14:40
@victormlg victormlg requested a review from larsewi June 10, 2025 15:06
@larsewi larsewi requested a review from jakub-nt June 11, 2025 07:16
Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you will have to derive os_version_minor from somewhere else on Windows. We don't want it to be "Unknown" on supported platforms.

@victormlg
Copy link
Contributor Author

@cf-bottom jenkins, please

@cf-bottom
Copy link

@larsewi
Copy link
Contributor

larsewi commented Jun 24, 2025

Build for Windows (no tests)
Build Status
Packages here

Ticket: ENT-8118
Changelog: Title
Signed-off-by: Victor Moene <[email protected]>
@olehermanse olehermanse requested a review from larsewi June 24, 2025 13:50
@victormlg
Copy link
Contributor Author

I tested sys.os_version_minor on a win-2019-dev-v8 ami and got the following:

image

It looks like it is working. It's difficult to make sense of a "os version minor" on this type of machine. Here is the version of the OS that I got by running winver

image

@victormlg victormlg requested a review from olehermanse June 24, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants