ENT-13041: install-dependencies: documented and refactored script #1826
+117
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting a PR! Maybe @craigcomstock can review this? |
There's a function in the detect-environment script to detect the number of available cores on the build host. However, this is overwritted in the install-dependencies script with a comment stating that some builds don't support multiple jobs. Let's see if this statement still holds. Ticket: ENT-13041 Signed-off-by: Lars Erik Wik <[email protected]>
Also did a little refactoring. If statements are more readable then `[ <COND> ] && <STMT>` in my opinion. Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
It very verbose. Better to enable it on specific scripts when debugging and instead add more debug log messages. Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
larsewi
force-pushed
the
install-dependencies
branch
from
29a8de1 to
f28930a
Compare
and added debug log messages Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
larsewi
force-pushed
the
install-dependencies
branch
from
f28930a to
1cd5c5a
Compare
olehermanse
reviewed
Aug 4, 2025
olehermanse
approved these changes
Aug 4, 2025
Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
larsewi
force-pushed
the
install-dependencies
branch
from
1cd5c5a to
c884121
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build with no tests:
