Sync Javascript Binding - Add support for property interception

[santoshmgh]

Summary:

• I have added property interceptor for Javascript Binding

Changes:

• I have modified the TryGetProperty and TrySetProperty in JavascriptObjectRepository
• I have PropertyInterceptor as the BindingOptions
• Added IPropertyInterceptor to CefSharp.ModelBinding
• Added new Unit Test cases for Property Interceptor to CefSharp.Test.JavascriptBinding.JavaScriptObjectRepositoryFacts
  How Has This Been Tested?
• I have tested it using CefSharp.Wpf.Example

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Updated documentation

Checklist:

• Tested the code(if applicable)
• Commented my code
• Changed the documentation(if applicable)
• New files have a license disclaimer
• The formatting is consistent with the project (project supports .editorconfig)

[AppVeyorBot]

❌ Build CefSharp 97.0.80-CI4345 failed (commit 2d6bd9d484 by @)

[santoshmgh]

@amaitland Kindly let me know if I am missing anything for the failing test case.

[amaitland]

The failing test is #3867

Property interception is not available in .Net Core and will need to be excluded with an if def see https://github.com/cefsharp/CefSharp/blob/master/CefSharp/Internals/JavascriptObjectRepository.cs#L197 for example.

[AppVeyorBot]

✅ Build CefSharp 97.0.80-CI4346 completed (commit 3869b1e24d by @santoshmgh)

[AppVeyorBot]

✅ Build CefSharp 97.0.80-CI4348 completed (commit 444a31e58a by @santoshmgh)

[santoshmgh]

@amaitland Are we good to merge these changes?

[amaitland]

Property interception is not available in .Net Core and will need to be excluded with an if def see https://github.com/cefsharp/CefSharp/blob/master/CefSharp/Internals/JavascriptObjectRepository.cs#L197 for example.

This will need to be addressed before this PR can be considered for merge.

A unit test should also be added. Testing the JavaScript object repository functionality directly should be sufficient. Add test to https://github.com/cefsharp/CefSharp/blob/master/CefSharp.Test/JavascriptBinding/JavaScriptObjectRepositoryFacts.cs

[santoshmgh]

@amaitland
Thanks for sharing the above pointer.
If my understanding is correct Property interception execution in TryGetProperty and TrySetProperty should be excluded for NETCOREAPP. Please confirm.
Example: : TryGetProperty

#if NETCOREAPP
                result = property.GetValue(obj.Value);
#else
                if (obj.PropertyInterceptor == null)
                {
                    result = property.GetValue(obj.Value);
                }
                else
                {
                    result = obj.PropertyInterceptor.InterceptGet(() => property.GetValue(obj.Value), property.ManagedName);
                }
#endif

Additional Query
Should I need to take care of the same at any other place apart from TryGetProperty and TrySetProperty API?

[amaitland]

Example: : TryGetProperty

To simplify things the whole TryGetProperty method can be excluded from the netcore implementation.

Should I need to take care of the same at any other place apart from TryGetProperty and TrySetProperty API?

Yes. You will need to compile the netcore solution and resolve all the errors.

[amaitland]

Comments inline

[amaitland]

@santoshmgh Please confirm if you are planning on implementing the required changes or if the PR should be closed. Thanks.

[santoshmgh]

@amaitland I will be incorporating the above comments..

[santoshmgh]

@amaitland Kindly let me know if I need to incorporate any other comments.

[AppVeyorBot]

❌ Build CefSharp 97.1.10-CI4377 failed (commit 25be78c73a by @santoshmgh)

[AppVeyorBot]

❌ Build CefSharp 97.1.10-CI4383 failed (commit ace575dbc4 by @santoshmgh)

[santoshmgh]

@amaitland Kindly let me know how can I run the test case from CefSharp.Test.dll locally. So that I can fix the failing test case.

[amaitland]

Added new QUnit Test cases PropertyInterceptorLogger to CefSharp.Example.ModelBinding

I don't see a qunit test. Can you re-add it please.

Kindly let me know how can I run the test case from CefSharp.Test.dll

Tests can be run from within Visual Studio, nothing special required.

[AppVeyorBot]

❌ Build CefSharp 97.1.10-CI4384 failed (commit 29c1760294 by @santoshmgh)

[santoshmgh]

@amaitland Added the unit test cases to CefSharp.Test.JavascriptBinding.JavaScriptObjectRepositoryFacts

[AppVeyorBot]

❌ Build CefSharp 97.1.10-CI4385 failed (commit 46e6880dde by @santoshmgh)

[amaitland]

Added the unit test cases to CefSharp.Test.JavascriptBinding.JavaScriptObjectRepositoryFacts

Please add a separate test case rather than modifying the existing one.

[AppVeyorBot]

✅ Build CefSharp 97.1.10-CI4392 completed (commit 7a34d91588 by @santoshmgh)

[santoshmgh]

@amaitland I have added a separate test case for property Interceptor. Please let me know if you want to update the test name to something else.

[amaitland]

Thanks. I'm not too worried about test naming, they can always be improved later without impacting anyone.

[AppVeyorBot]

✅ Build CefSharp 98.1.120-CI4395 completed (commit 1b5ff45b0e by @santoshmgh)

[santoshmgh]

@amaitland Please confirm if changes for property interceptor will be available as part of cefsharp 98 release.

[amaitland]

@santoshmgh If you look at the Milestone you'll see this has already been added to 98.1.x.