feat(theme): implement UTF-8 checkbox and radiobox

[slook]

• Changed: Use UTF-8 glyphs for TTkCheckBox and TTkRadioButton, because "X" looks ambiguous with "off" or "no".

The ASCII theme looks unchanged but now uses the theme system, as it currently stands, as intended.

If the border edge parts now look a bit weird in combination with the inner boxes then perhaps in future border glyphs can be added to allow customizing those as well. Perhaps the theme system will be removed sometime soon and it shall be possible to customize more of the elements using style attributes to alter the individual glyphs as desired, but these are sensible defaults.

[ceccopierangiolieugenio]

Thanks,

This thing is something I had in my backlog for ages,
As you pointed I want to get rid of the Themes class and include the glyphs inside the classStyle,

Except for the NerdFonts (used only in the file icons),
I think I will drop the ascii support because I am not actively testing it and because only some rare edge cases (GPM/TTY) actually needs it.

The reason I didn't make this change yet in the checkbox is for laziness and also because I want to get rid of the parenthesis and this would drop the size from 3 to 1 and I am not sure which issues it would cause.

Anyway keeping the parenthesis is something I haven't considered and it doesn't looks bad, it could be a good solution for now.

[slook]

I think I will drop the ascii support ... only some rare edge cases (GPM/TTY) actually needs it.

Then it should be kept at least for that type of fallback scenario. Ideally the terminal driver would automatically detect if there are no unicode support and display the ASCII theme characters instead. The rudimentary aesthetic of it has an intrinsic value so it shouldn't be dropped. Also, since there is only one other theme at the moment, it provides a base for structuring the planned classStyle implementation for the sake of testing support of custom glyphs/themes.

I want to get rid of the parenthesis and this would drop the size from 3 to 1 and I am not sure which issues it would cause

I tried doing this but the unicode boxes look too small when they are on their own. Perhaps some other box art characters would be desirable for a more central alignment than standard brackets, but in any case at least one padding is needed on either side.

[ceccopierangiolieugenio]

for some reason it is glitching on my terminal (ghostty)

it seems an issue with the font used (Jetbrains Mono)

raised:
JetBrains/JetBrainsMono#740

[slook]

That's quite a popular font I would imagine. What about using just a regular box square like ■ or ▨ or ☑ instead of ▣, since the outlined square isn't really needed since we're keeping the outer brackets anyway, does that avoid the faulty character fallback?

[ceccopierangiolieugenio]

I'll wait few weeks, if I notice that no progress, probably we can switch back to the simple block.

[slook]

The simple block might be a better choice anyway, since on terminals without extended unicode support all three of the special checkbox characters are missing which means they all look like diamonds (the placeholder character).

[ceccopierangiolieugenio]

It seems a fix is on the way with ghostty,
I reported it here:

ghostty-org/ghostty#8822 (comment)

[ceccopierangiolieugenio]

I will probably roll back to the square in the next release and keep a note to check when the fix will be available

[ceccopierangiolieugenio]

Just checked the comments and I it seems that the very last release fixed it:

Still it is not perfect but aligned much better.

ghostty-org/ghostty#8822 (comment)