fix(textcursor): correct number of Up/Down movements - #512
Merged
ceccopierangiolieugenio merged 1 commit intoNov 8, 2025
Merged
Conversation
ceccopierangiolieugenio
merged commit Nov 8, 2025
6410b77
into
ceccopierangiolieugenio:main
11 checks passed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nbecause it is already iterated for the required number of movePosition operations as this sub-procedure is called from within aforloop.In future it might be considered better performance to do all moves in one go for relevant operations (Up, Down, Left, Right), but for now this at least fixes the function that was otherwise off by
norders of magnitude whennis more than1.