-
Notifications
You must be signed in to change notification settings - Fork 236
Register missing task inputs for Develocity test distribution #2149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Fixes #1790 The `paparazzi.test.resources` system property references output from `writeResourcesTask`, but this dependency wasn't registered as a task input. Similarly, `layoutlibResourcesFileCollection` was being used in system properties but wasn't registered as an input. This caused failures when using Develocity's test distribution, as the required files weren't uploaded. Now both properties are registered as task inputs with PathSensitivity.NONE: - paparazzi.test.resources (from writeResourcesTask output) - paparazzi.resources (from layoutlibResourcesFileCollection)
geoff-powell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, do you have an example of before and after where this is working? Maybe via a build scan
I'm not exactly sure how to manually test this out. Do you have any thoughts here how to trigger a build scan or another way to verify this before/after? |
|
Are we sure NONE is the right sensitivity? If the files are relocated, wouldn't we need to invalidate the inputs and re-run the task? Or is that not what it means? |
You can run whatever task like |
I got a build scan here: https://scans.gradle.com/s/u37l6sna4uhao, tried looking around for the inputs but I can't seem to find them 🤔 |
I don't think the paths are relevant here and only the content of these matter for the invalidation. Happy to change this if there is something I'm missing here though! |
Summary
Fixes #1790
This PR registers two missing task inputs that were causing failures when using Develocity's test distribution feature:
writeResourcesTaskthat's used as a system propertylayoutlibResourcesFileCollectionused in system propertiesBoth are now properly registered as task inputs with
PathSensitivity.NONE, ensuring these files are uploaded when using Develocity test distribution.