Skip to content

Conversation

@colinmarsch
Copy link
Collaborator

@colinmarsch colinmarsch commented Nov 13, 2025

Summary

Fixes #1790

This PR registers two missing task inputs that were causing failures when using Develocity's test distribution feature:

  1. paparazzi.test.resources - The output file from writeResourcesTask that's used as a system property
  2. paparazzi.resources - The layoutlibResourcesFileCollection used in system properties

Both are now properly registered as task inputs with PathSensitivity.NONE, ensuring these files are uploaded when using Develocity test distribution.

Fixes #1790

The `paparazzi.test.resources` system property references output from
`writeResourcesTask`, but this dependency wasn't registered as a task
input. Similarly, `layoutlibResourcesFileCollection` was being used in
system properties but wasn't registered as an input.

This caused failures when using Develocity's test distribution, as the
required files weren't uploaded.

Now both properties are registered as task inputs with PathSensitivity.NONE:
- paparazzi.test.resources (from writeResourcesTask output)
- paparazzi.resources (from layoutlibResourcesFileCollection)
Copy link
Collaborator

@geoff-powell geoff-powell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, do you have an example of before and after where this is working? Maybe via a build scan

@colinmarsch
Copy link
Collaborator Author

Nice, do you have an example of before and after where this is working? Maybe via a build scan

I'm not exactly sure how to manually test this out. Do you have any thoughts here how to trigger a build scan or another way to verify this before/after?

@TWiStErRob
Copy link
Contributor

Are we sure NONE is the right sensitivity? If the files are relocated, wouldn't we need to invalidate the inputs and re-run the task? Or is that not what it means?

@geoff-powell
Copy link
Collaborator

I'm not exactly sure how to manually test this out. Do you have any thoughts here how to trigger a build scan or another way to verify this before/after?

You can run whatever task like export CI="true" && ./gradlew :sample:verifyPaparazziDebug to publish build scan

@colinmarsch
Copy link
Collaborator Author

I'm not exactly sure how to manually test this out. Do you have any thoughts here how to trigger a build scan or another way to verify this before/after?

You can run whatever task like export CI="true" && ./gradlew :sample:verifyPaparazziDebug to publish build scan

I got a build scan here: https://scans.gradle.com/s/u37l6sna4uhao, tried looking around for the inputs but I can't seem to find them 🤔

@colinmarsch
Copy link
Collaborator Author

Are we sure NONE is the right sensitivity? If the files are relocated, wouldn't we need to invalidate the inputs and re-run the task? Or is that not what it means?

I don't think the paths are relevant here and only the content of these matter for the invalidation. Happy to change this if there is something I'm missing here though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing task input

3 participants