Refresh reviews with pySHACL 0.20.0 #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pySHACL 0.20.0, recently released, includes support for incorporating ill-typedness of literals in review of SHACL Datatype Constraints. For unknown reasons, this is now causing some `xsd:decimal` literals to be flggged as non-conformant. This is being discussed further in pySHACL PR 157. References: * RDFLib/pySHACL#157 Signed-off-by: Alex Nelson <[email protected]>
2 tasks
JSON-LD has a default conversion of non-integer literals to `xsd:double`, per Section B.1.3 of the JSON-LD 1.1 specification. What does not appear to be explained in the specification---at least, in that section---is what to do when there is an `@type` annotation accompanying a non-string `@value`. RDFLib, at least as of 6.2.0, does not use the `@type` annotation. This makes the pySHACL output look quite mysterious. This patch converts the `@value` to a string so `@type` will be respected. A follow-on patch will regenerate Make-managed files. References: * https://w3c.github.io/json-ld-syntax/#conversion-of-native-data-types Signed-off-by: Alex Nelson <[email protected]>
References: * https://w3c.github.io/json-ld-syntax/#conversion-of-native-data-types Signed-off-by: Alex Nelson <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.